Review Request 128752: Mark invalid entries during practice and enable fixing in editor

[Hartmut Riesenbeck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128752/#review99128
-----------------------------------------------------------



Read your comment on Julians review (https://git.reviewboard.kde.org/r/127891/). I agree with you for that point of a more distinct workflow. My personal workflow is similar to your approach. I note the respective word on a paper - of course old school ;-) - and edit them after the learning session. Edit these invald words and may research for correctness during learning would disturb the learning session for my point of view.
But one point I miss in your approach. If the number of vocabularies is very big, it's hard to find one or two invalid ones in the editor. A kind of filter, which shows only the invalid lines would be very helpfull.

- Hartmut Riesenbeck


On Aug. 25, 2016, 9:54 vorm., Dimitris Kardarakos wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128752/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2016, 9:54 vorm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 170534
>     http://bugs.kde.org/show_bug.cgi?id=170534
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> During practicing, users may stumble upon an invalid entry
> (typo, wrong match, etc). To enable users to timely handle these entries, in
> practice main window, a new button (Invalid Entry) has been added. As soon as
> users click on it, the current entry is set as invalid (deactivated), it is
> excluded from the practice as well as from future practices. Session flow
> moves on to the next entry.After the completion of the practice (or later)
> users may navigate to the editor so as to fix invalid entries. These entries
> can be identified by their negative (red) color. In Edit menu, a new action
> to toggle activation status has been added. User may select a single or more
> entries and toggle their activation status after fixing them. Valid entries'
> color is set to non-negative again.
> 
> 
> Diffs
> -----
> 
>   src/collection/entryfilter.cpp a68c30d 
>   src/collection/testentry.h a43eb6f 
>   src/collection/testentry.cpp 3e152f1 
>   src/collection/vocabularymodel.cpp 582701b 
>   src/editor/editorui.rc c9c928e 
>   src/editor/vocabularyview.h 3730508 
>   src/editor/vocabularyview.cpp 2760c06 
>   src/practice/abstractfrontend.h f5f9552 
>   src/practice/guifrontend.cpp 4ee6348 
>   src/practice/practice_mainwindow.ui 00864ac 
>   src/practice/practicestatemachine.h b67ba32 
>   src/practice/practicestatemachine.cpp bc03ffe 
> 
> Diff: https://git.reviewboard.kde.org/r/128752/diff/
> 
> 
> Testing
> -------
> 
> Start practice
> Mark 1st entry as invalid
> Mark 2nd entry as invalid
> Continue and finish
> View summary (the invalids are marked as unanswered)
> Open editor
> Fix an invalid entry
> Toggle activation status (so as to be included to future practices)
> 
> 
> File Attachments
> ----------------
> 
> Short demo of the functionality
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/08/25/c011d3d0-8151-459e-98a5-39961fd812fc__parleyFixInvalids.webm
> 
> 
> Thanks,
> 
> Dimitris Kardarakos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160912/eb765dc5/attachment.html>