Review Request 129523: Fix desktop file command line
Sebastian Gottfried
sebastian.gottfried at posteo.de
Wed Nov 23 11:14:41 UTC 2016
> On Nov. 21, 2016, 8:27 nachm., Aleix Pol Gonzalez wrote:
> > org.kde.ktouch.desktop, line 4
> > <https://git.reviewboard.kde.org/r/129523/diff/1/?file=486382#file486382line4>
> >
> > Out of curiosity, what's the point of passing this? Shouldn't `Exec=ktouch` be enough?
I guess for historic reasons, the current line is basically in place since the inception of the desktop file. During its 5 year history only one other argument has been removed which have been deprecated in the mean time. I can't think of reason why to pass the other stuff.
I would opt for `Exec=ktouch` as well.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129523/#review101037
-----------------------------------------------------------
On Nov. 21, 2016, 7:16 nachm., Antonio Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129523/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2016, 7:16 nachm.)
>
>
> Review request for KDE Edu and Sebastian Gottfried.
>
>
> Repository: ktouch
>
>
> Description
> -------
>
> Remove obsolete parameter that breaks the launcher
>
>
> Diffs
> -----
>
> org.kde.ktouch.desktop f61b2a2
>
> Diff: https://git.reviewboard.kde.org/r/129523/diff/
>
>
> Testing
> -------
>
> ktouch can be launched again from krunner or kickoff
>
>
> Thanks,
>
> Antonio Rojas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161123/6871d3c9/attachment.html>
More information about the kde-edu
mailing list