Review Request 128926: More robust version check for Sage

[Antonio Rojas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128926/
-----------------------------------------------------------

(Updated Nov. 1, 2016, 2:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Filipe Saraiva.


Changes
-------

Submitted with commit 8d3d07a683ca6758eada1cd8442047401c0fa83d by Antonio Rojas to branch master.


Repository: cantor


Description
-------

Version check for Sage is once again broken with the latest version. Instead of relying on parsing the sage banner, which is likely to break with changes in Sage output format, use the dedicated 'sage -v' command.


Diffs
-----

  src/backends/sage/sagesession.cpp bd2c3dc 

Diff: https://git.reviewboard.kde.org/r/128926/diff/


Testing
-------

Correct version is detected again according to the console output. Note that the backend is still broken with latest Sage, but that's a separate issue.


Thanks,

Antonio Rojas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161101/3087e242/attachment.html>