Review Request 116629: Parley plugin mwclient bug workaround: using standard urllib library for download instead of calling download() on wikiObject

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116629/#review95920
-----------------------------------------------------------


Ship it!




Sorry for taking this excessive amount of time! The patch is fine and fixes the named problem.
Thanks I a lot, I will directly commit this on your behalf bevor it gets lost again.

- Andreas Cord-Landwehr


On April 23, 2014, 11:06 nachm., Maximilian Reiner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116629/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 11:06 nachm.)
> 
> 
> Review request for KDE Edu and Inge Wallin.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Parley plugin mwclient bug workaround: fetching content by calling wikiObject.download() raised a http 404 error, but urllib's open/read method works as expected on an existing URI.
> 
> 
> Diffs
> -----
> 
>   plugins/wiktionary/wiktionary_sound.py 92074bf 
> 
> Diff: https://git.reviewboard.kde.org/r/116629/diff/
> 
> 
> Testing
> -------
> 
> Using urlopen/read from the standard urllib library delivers object's content with http status 200 OK.
> 
> 
> Thanks,
> 
> Maximilian Reiner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160527/c5589fdc/attachment-0001.html>