Review Request 127958: Fix Coverty Scan ID 1342042 - Explicit null dereferenced

Hartmut Riesenbeck hartmut.riesenbeck at gmx.de
Thu May 19 20:21:06 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127958/
-----------------------------------------------------------

(Updated Mai 19, 2016, 8:21 nachm.)


Review request for KDE Edu.


Changes
-------

Changes made in response to the rewiew of Aleix Pol Gonzalez.


Repository: parley


Description
-------

KGameThemeSelectorPrivate::_k_updateThemeList() was made more robust to
prevent null pointer access when an entry in themeMap was not found.
For this case the value() method returns a null pointer which was not
checked before refactoring.


Diffs (updated)
-----

  src/settings/kgametheme/kgamethemeselector.cpp dc896d5792e6090f63dfb54c6c377e5971f41aeb 

Diff: https://git.reviewboard.kde.org/r/127958/diff/


Testing
-------


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160519/34ff4155/attachment.html>


More information about the kde-edu mailing list