Review Request 127958: Fix Coverty Scan ID 1342042 - Explicit null dereferenced

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127958/#review95598
-----------------------------------------------------------




src/settings/kgametheme/kgamethemeselector.cpp (line 194)
<https://git.reviewboard.kde.org/r/127958/#comment64766>

    I'd say doing `!currentItem` is perfectly fine, if not preferred.
    
    In fact, it looks to me like the logic is being changed. Can you please make sure?


- Aleix Pol Gonzalez


On May 18, 2016, 9:52 p.m., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127958/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 9:52 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> KGameThemeSelectorPrivate::_k_updateThemeList() was made more robust to
> prevent null pointer access when an entry in themeMap was not found.
> For this case the value() method returns a null pointer which was not
> checked before refactoring.
> 
> 
> Diffs
> -----
> 
>   src/settings/kgametheme/kgamethemeselector.cpp dc896d5792e6090f63dfb54c6c377e5971f41aeb 
> 
> Diff: https://git.reviewboard.kde.org/r/127958/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160518/ed924f2e/attachment.html>