Review Request 127891: Parley: Quickly edit vocabularies during practice

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127891/
-----------------------------------------------------------

Review request for KDE Edu and KDE Usability.


Bugs: 170534
    http://bugs.kde.org/show_bug.cgi?id=170534


Repository: parley


Description
-------

I have implemented a wish request (bug 170534) I would very much see in Parley: Add an option to edit the vocabulary during practice. To keep the review request small, I have implemented the quick edit option only for Flashcard practice. However, the approach is easy to extend.

I took the following approach:

* The QLabel displaying the question/solution is replaced by a custom widget.
* The widget is designed to behave similar to a QLabel, but it adds an additional action to the right-click context menu: "Edit vocabulary entry" (see screenshot 1).
* When this option is selected, the QLabel is swapped with a QLineEdit and two ToolButtons for "Accept" and "Cancel" (see screenshot 2).
* Clicking the "Cancel" button brings back the Label displaying the question/solution.
* Clicking the "Accept" button or pressing enter brings back the question/solution label and emits the entryEdited() signal.
* This signal is passed on to Practice State Machine as questionEdited() or solutionEdited() which modifies the vocabulary entry.

The approach does not make the quick edit option very obvious. Instead, I have opted for not changing the look and feel of the application. Another option would be to add an "edit" ToolButton (see screenshot 3).


Diffs
-----

  src/CMakeLists.txt fd352de 
  src/practice/abstractfrontend.h f5f9552 
  src/practice/editable_label.ui PRE-CREATION 
  src/practice/editablelabel.h PRE-CREATION 
  src/practice/editablelabel.cpp PRE-CREATION 
  src/practice/flashcardmodewidget.cpp ced6ca6 
  src/practice/practice_widget_flashcard.ui e1aa099 
  src/practice/practicestatemachine.h b67ba32 
  src/practice/practicestatemachine.cpp 8756592 
  src/practice/rightclickeditlabel.h PRE-CREATION 
  src/practice/rightclickeditlabel.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127891/diff/


Testing
-------

Flashcard practice.

Started editing -> Canceled edit
Started editing -> Accepted edit -> Confirmed that vocabulary was modified
Started editing -> Pressed continue/Answer later/Hint


File Attachments
----------------

Additional context menu entry
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/11/f2db895e-c290-4548-9547-fd978c368893__context_menu.png
Edit vocabulary entry
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/11/6b602f41-fb17-43ec-a98e-7155f6721489__edit_entry.png
Edit tool button
  https://git.reviewboard.kde.org/media/uploaded/files/2016/05/11/8098a66e-eb34-430a-951a-1da21529b4ba__toolbutton.png


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160511/a0b7936e/attachment-0001.html>