Review Request 127663: Fix Coverty Scan ID 1343237 - Unused value

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127663/#review95054
-----------------------------------------------------------


Ship it!




Ship It!

- Andreas Cord-Landwehr


On April 16, 2016, 9:26 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127663/
> -----------------------------------------------------------
> 
> (Updated April 16, 2016, 9:26 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> The coverty scan issue in BlockOptions::checkValidity() was fixed by
> moving the boolean variable "found" outside the for loop. By this it
> wouldn't reset to false at the beginning of each loop cycle and works
> now as expected.
> 
> By the way BlockOptions::checkValidity() was refactored to run the for
> loops only when checkboxes are enabled. Also a validy check was added
> when check boxes becomes checked. Removed unused QString variable.
> 
> Defined the boolean variable "found" new before each for loop to make it clear that its only used into this loop.
> 
> 
> Diffs
> -----
> 
>   src/practice/configure/blockoptions.cpp a9a8032e787c82bb572b60e15e51468bc7cc825c 
> 
> Diff: https://git.reviewboard.kde.org/r/127663/diff/
> 
> 
> Testing
> -------
> 
> Tested the configure lesson dialog manualy by selecting appropriate values for blocking and expiering to make the warning message box appear.
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160501/595422a7/attachment-0001.html>