Review Request 127783: libkeduvocdocument: Remove deprecated method calls

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127783/#review95052
-----------------------------------------------------------


Fix it, then Ship it!





keduvocdocument/autotests/keduvocdocumenttest.cpp (line 28)
<https://git.reviewboard.kde.org/r/127783/#comment64511>

    "proof expected behavior befor" -> "prove expected behavior before"


- Andreas Cord-Landwehr


On April 28, 2016, 8:34 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127783/
> -----------------------------------------------------------
> 
> (Updated April 28, 2016, 8:34 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> The following methods were edited:
> + KEduVocDocument::detectFileType()
> + KEduVocDocument::open()
> + KEduVocKvtmlReader::readArticle()
> + KEduVocKvtmlReader::readComparison()
> 
> KEduVocDocument::detectFileType() and KEduVocDocument::open() have been reformanted to current coding style.
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/autotests/CMakeLists.txt ef375d3d2b2372a6345613f60b23e51767e45e32 
>   keduvocdocument/autotests/keduvocdocumenttest.cpp PRE-CREATION 
>   keduvocdocument/keduvocdocument.h 6ed2683e79a9d9f6375939c7470864d2399d58c5 
>   keduvocdocument/keduvocdocument.cpp feaebe45d98ec5e862dbb7b8e95c142a7d59c7ff 
>   keduvocdocument/readerwriters/keduvockvtmlreader.cpp 89af6696f87ac1ee9a600721c5f8b951c478a2f7 
> 
> Diff: https://git.reviewboard.kde.org/r/127783/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for detectFileType() and open() were added.
> 
> Added no tests for readArticle() and readComparsion() because I simply copied code from the deprecated method (readArticle) respectively changed to new method wich does at least the same than the depricated (readComparison). If anyone thinks that tests for this methods should added, I will try it.
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160501/82df2d61/attachment.html>