Review Request 127505: Parley: Randomize order of letters in Mixed Letters Practice

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127505/
-----------------------------------------------------------

(Updated March 27, 2016, 7:32 p.m.)


Review request for KDE Edu and Inge Wallin.


Changes
-------

Small change in the description.


Bugs: 360239
    http://bugs.kde.org/show_bug.cgi?id=360239


Repository: parley


Description (updated)
-------

The order of letters in the Mixed Letter Practice is currently not randomized. Instead, the letters are only shifted vertically (see bug 360239).

Now, I use KRandomSequence::randomize() to shuffle the list of characters comprising the solution. The KRandomSequence is a member of MixedLettersModeWidget. Thus, it gets instantiated each time the Mixed Letters Practice is started. I also use KRandomSequence::getInt() instead of KRandom::random() for consistency.

I have added Inge Wallin to the reviewers, because they replaced KRandomSequence with KRandom about a year ago. Is there a good reason not to use KRandomSequence?


Diffs
-----

  src/practice/mixedlettersmodewidget.h f2acaa1 
  src/practice/mixedlettersmodewidget.cpp adc53cd 

Diff: https://git.reviewboard.kde.org/r/127505/diff/


Testing
-------

Build and tested on Kubuntu 15.10:

Practiced vocabulary using Mixed Letter Practice and confirmed that letters are randomized.


Thanks,

Julian Helfferich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160327/692f612c/attachment.html>