Review Request 127441: Fix never ending event loop when quitting app and segmentation faults

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127441/#review93808
-----------------------------------------------------------



I do not think that this is the correct approach for this problem. The commented issues below seem to only touch symptoms but not the real problem.
Can you try to get some more verbose output by e.g. Valgrind?


src/parleydocument.cpp 
<https://git.reviewboard.kde.org/r/127441/#comment63926>

    Don't we get a resource leak now?



src/parleymainwindow.cpp (lines 132 - 133)
<https://git.reviewboard.kde.org/r/127441/#comment63927>

    I do not see why is solves the problem. If possible, we always prefer the function pointer ways, since it is faster and ensures that the call is correct at compile time. (Neglecting corner cases, the only reason why one sometimes still uses the old mechanism is when one creates QML bindings.)


- Andreas Cord-Landwehr


On März 20, 2016, 7:49 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127441/
> -----------------------------------------------------------
> 
> (Updated März 20, 2016, 7:49 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> When the app is quited app.exec() doesn't return. The process stays in
> sleeping state. Removed app.setQuitOnLastWindowClosed(false) because
> the quit() or exec() method of the application were not invoked
> somewhere else in the application.
> 
> After this the app ends in the correct way. But after quit is invoked,
> there are sporadic segmentation faults and the following message was
> shown on stderr:
>     QCoreApplication::postEvent: Unexpected null receiver
> This was fixed by removing zero pointer access in destuctor of
> ParleyDocument and adding SIGNAL SLOT macros into connect statement in
> ParleyMainWidow.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 2e87baa93f81349a187d620be2468f8a1bb4aca1 
>   src/parleydocument.cpp cf4c81c3f8f35a99389d61a75d934cff3170b960 
>   src/parleymainwindow.cpp d6f86debd32c1e77bbcca86a160906674960dce9 
> 
> Diff: https://git.reviewboard.kde.org/r/127441/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160321/e9f8e2bc/attachment.html>