Review Request 127354: improve drawing precision for circles

[Maurizio Paolini]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127354/
-----------------------------------------------------------

(Updated March 19, 2016, 9:05 a.m.)


Review request for KDE Edu, David Narváez and Rex Dieter.


Changes
-------

added a picture of two tangent circles as they appear before and after the proposed patch


Bugs: 359805
    http://bugs.kde.org/show_bug.cgi?id=359805


Repository: kig


Description
-------

QRect object in qt uses integers.  This causes annoying loss of drawing precision when drawing circles (https://bugs.kde.org/show_bug.cgi?id=359805).  Using the QRectF object seems more appropriate.


Diffs
-----

  misc/kigpainter.h e36c153 
  misc/kigpainter.cpp e547bf2 
  misc/screeninfo.h b7f94c4 
  misc/screeninfo.cc 8fdf115 

Diff: https://git.reviewboard.kde.org/r/127354/diff/


Testing
-------

This is a minimal patch to allow using QRectF when drawing circles.  Perhaps using QRect
(and QPoint) could be dropped completely in favour of QRectF and QPointF.


File Attachments (updated)
----------------

tangent circles - old behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/48f5447f-0904-43ee-8c56-8fc07c03febb__circles_old.png
tangent circles: new behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/5684b1c5-c32c-447b-bed6-53be380f1b87__circles_new.png
zoom of old behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/08937b54-e313-4acf-b482-4bd899d24b30__circles_old_zoom.png
zoom of new behaviour
  https://git.reviewboard.kde.org/media/uploaded/files/2016/03/19/e7c0b8fb-af81-43da-b70e-bed3462d73a6__circles_new_zoom.png


Thanks,

Maurizio Paolini

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160319/ac83a2f1/attachment-0001.html>