Review Request 125981: Search box resetting after 50 lookups

Dametrious Peyton dametriouspeyton at
Thu Mar 10 17:53:30 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated March 10, 2016, 5:53 p.m.)


This change has been marked as submitted.

Review request for KDE Edu.


Submitted with commit 9c85c2ae0513e696c77368d5e3f43e7e5357888e by Andreas Cord-Landwehr on behalf of Dametrious Peyton to branch master.

Repository: kiten


After reaching the maximum history count (about 50 by default), the combo box would remove the searched item and replace it with the last entry in the history. The fix is to add the last searched item to the history, set the item in the combo box, and reset the history to sync.
    reset() is required according to the KDE API Doc.


  app/searchstringinput.cpp ac0130b 



Did functional testing with the search box


Dametrious Peyton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-edu mailing list