Review Request 125981: Search box resetting after 50 lookups

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125981/#review93370
-----------------------------------------------------------


Ship it!




Thanks for your contribution and sorry for the late answer!
Do you have commit access or shall I commit it for you?

- Andreas Cord-Landwehr


On Nov. 6, 2015, 11:28 nachm., Dametrious Peyton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125981/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:28 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: kiten
> 
> 
> Description
> -------
> 
> After reaching the maximum history count (about 50 by default), the combo box would remove the searched item and replace it with the last entry in the history. The fix is to add the last searched item to the history, set the item in the combo box, and reset the history to sync.
>     
>     reset() is required according to the KDE API Doc. http://api.kde.org/frameworks-api/frameworks5-apidocs/kcompletion/html/classKHistoryComboBox.html#af6ef37548be290c810e1603350393780
> 
> 
> Diffs
> -----
> 
>   app/searchstringinput.cpp ac0130b 
> 
> Diff: https://git.reviewboard.kde.org/r/125981/diff/
> 
> 
> Testing
> -------
> 
> Did functional testing with the search box
> 
> 
> Thanks,
> 
> Dametrious Peyton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160309/54c8f9df/attachment.html>