Review Request 127310: [rocs] Make KF5DocTools really optional

Andreas Cord-Landwehr cordlandwehr at kde.org
Tue Mar 8 21:20:56 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127310/#review93313
-----------------------------------------------------------


Ship it!




Ship It!

- Andreas Cord-Landwehr


On März 8, 2016, 9:07 nachm., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127310/
> -----------------------------------------------------------
> 
> (Updated März 8, 2016, 9:07 nachm.)
> 
> 
> Review request for KDE Edu and Andreas Cord-Landwehr.
> 
> 
> Repository: rocs
> 
> 
> Description
> -------
> 
> There's already an optional lookup for KF5DocTools at the beginning of root CMakeLists.txt, so it can be removed from required KF5 deps. Further down, only add doc subdirectory if KF5DocTools_FOUND.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt cc71ba0705795f0e53f2a38b57e9b020e57bf6fd 
> 
> Diff: https://git.reviewboard.kde.org/r/127310/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160308/ce116fb3/attachment.html>


More information about the kde-edu mailing list