Review Request 127157: Prevent array access with negativ index

[Hartmut Riesenbeck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127157/
-----------------------------------------------------------

(Updated March 1, 2016, 7:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu.


Changes
-------

Submitted with commit a8af50583572e947b31a959797eb9bd06456ef06 by Andreas Cord-Landwehr on behalf of Hartmut Riesenbeck to branch master.


Repository: parley


Description
-------

To adjust the practice date of expired entries
in EntryFilter::expireEntries() the expire item
time was read from the Prefs object. When grade
of the expired item was 1, the argument of
Prefs::expireItem() became -1. This resulted in
an access of an C array with negativ index in
Prefs::expireItem(). For grade 2 the prefs value
was not defined in the config file - zero was
returned by default. For this two cases the
practice date was set to current time as a
defined state.


Diffs
-----

  src/collection/entryfilter.cpp 5264226 

Diff: https://git.reviewboard.kde.org/r/127157/diff/


Testing
-------


Thanks,

Hartmut Riesenbeck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160301/28bb1b74/attachment.html>