Review Request 128256: [Parley] Replace deprecated libkeduvocdocument methods

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128256/#review96825
-----------------------------------------------------------


Fix it, then Ship it!




LGTM, only a few nitpicks


src/dashboard/collectionwidget.cpp (line 93)
<https://git.reviewboard.kde.org/r/128256/#comment65408>

    if this method is not needed anymore, I would vote for removing it



src/dashboard/dashboard.cpp (line 42)
<https://git.reviewboard.kde.org/r/128256/#comment65409>

    same here



src/practice/configure/generalpracticeoptions.cpp (line 38)
<https://git.reviewboard.kde.org/r/128256/#comment65412>

    remove it



src/practice/conjugationbackendmode.cpp (line 153)
<https://git.reviewboard.kde.org/r/128256/#comment65410>

    the method might return a nullptr



src/practice/practicemainwindow.cpp (line 63)
<https://git.reviewboard.kde.org/r/128256/#comment65411>

    just remove it



src/statistics/statisticslegendwidget.cpp (line 70)
<https://git.reviewboard.kde.org/r/128256/#comment65413>

    same


- Andreas Cord-Landwehr


On Juni 19, 2016, 8:18 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128256/
> -----------------------------------------------------------
> 
> (Updated Juni 19, 2016, 8:18 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> With commit ddb743b of libkeduvocdocument some methods which returned
> non const refereces to private member values of KEduVocTranslation have
> been set as deprecated. These methods were replaced with new provided
> ones.
> 
> Some unused lines were commented out to make the compiling free of
> warnings.
> 
> 
> Diffs
> -----
> 
>   src/collection/entryfilter.cpp 8d6ca047380ac9ba464a5a1b425215df9759a324 
>   src/dashboard/collectionwidget.cpp 3d1ff3300cc86be7c4d341872e77d7bb4096f791 
>   src/dashboard/dashboard.cpp 978935e080ce5ef07a84364af2c618f892180b50 
>   src/editor/conjugationwidget.cpp d19d4fe7e7f23aec11192744c4cff6a576cbcbc6 
>   src/editor/multiplechoicewidget.cpp b0412e82c5cdd00925c7f7c22dd801aac551ff56 
>   src/practice/configure/generalpracticeoptions.cpp a4677bc84152d2cf019c48f972504151a468c760 
>   src/practice/conjugationbackendmode.cpp b57595ea7d008de300cf0d87405f6e85d89a5552 
>   src/practice/practicemainwindow.cpp 3ca2d4e92cc2ee2823c8430bad7d76001033c9d2 
>   src/practice/sessionmanagerbase.cpp bb4d08ca228ff00feb52179e80527bde69b0925e 
>   src/scripts/scripting/translation.h 5ef3ffe1eca6c7f309b182f9cee84f9559e0d9e2 
>   src/scripts/scripting/translation.cpp e8845117a6e297822a0ed32d4841e46e67d71274 
>   src/statistics/statisticslegendwidget.cpp 46d3a3434608602ab977c3aebde2308bfb13aaab 
> 
> Diff: https://git.reviewboard.kde.org/r/128256/diff/
> 
> 
> Testing
> -------
> 
> Tested manualy.
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160623/69f2574a/attachment.html>