Review Request 128128: Parley: Fix Coverty Scan ID 1342591 - Dereference before null check

[Hartmut Riesenbeck]

> On Juni 8, 2016, 8:23 nachm., Andreas Cord-Landwehr wrote:
> > src/editor/multiplechoicewidget.cpp, line 58
> > <https://git.reviewboard.kde.org/r/128128/diff/1/?file=468066#file468066line58>
> >
> >     that looks awkward, at least uncommon to use references here; I wonder why there is a method setMultipleChoice(...) which is commented out... maybe a code improvement in another review? :)

This setMultipleChoice(...) method looks to me, like it was planned to implement but gets than somehow lost. May it's a good idea to write getter / setter methots for the m_multipleChoice stinglist and set the non const reference method to deprecated state.
That seems to be no big job, so I will do it the next days.


- Hartmut


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128128/#review96301
-----------------------------------------------------------


On Juni 8, 2016, 7:49 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128128/
> -----------------------------------------------------------
> 
> (Updated Juni 8, 2016, 7:49 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> The m_translation pointer member of MultipleChoiceWidget class is now
> inititalized in constructor and missing null pointer checks before
> usage were added.
> 
> 
> Diffs
> -----
> 
>   src/editor/multiplechoicewidget.h c1522e5c6cd630e538fba61886f9dbf1faecced2 
>   src/editor/multiplechoicewidget.cpp bcfc5118a7aa54da18413682fab93f5d7116e8dd 
> 
> Diff: https://git.reviewboard.kde.org/r/128128/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160609/0adebe4c/attachment.html>