Review Request 128090: Drop qalculate settingswidget.* files
Albert Astals Cid
aacid at kde.org
Sun Jun 5 23:57:36 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128090/#review96212
-----------------------------------------------------------
Ship it!
Ship It!
- Albert Astals Cid
On June 3, 2016, 4:19 p.m., Maximiliano Curia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128090/
> -----------------------------------------------------------
>
> (Updated June 3, 2016, 4:19 p.m.)
>
>
> Review request for KDE Edu.
>
>
> Repository: cantor
>
>
> Description
> -------
>
> The files were licensed GPL-3+ in a GPL-2+ project, just to wrap the ui.
> The replacement function is based on the lua backend's settingsWidget
> function.
>
> This solves the bug #359918 (originally https://bugs.debian.org/792078)
>
>
> Diffs
> -----
>
> src/backends/qalculate/CMakeLists.txt d564da400053796985e05f0d472d9e4078a0436a
> src/backends/qalculate/qalculatebackend.cpp 3c589abb172793c6a182125a61b08c4c59301a7f
> src/backends/qalculate/settingswidget.h aa0251d884f53acb884793d3235fcdc71dbcceba
> src/backends/qalculate/settingswidget.cpp 625d352fe83f891c3db245d9e8dcf37134983fa4
>
> Diff: https://git.reviewboard.kde.org/r/128090/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maximiliano Curia
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160605/6ad4b1c2/attachment.html>
More information about the kde-edu
mailing list