Review Request 127717: Fix error when destroying an default constructed KEduVocDocument
Hartmut Riesenbeck
hartmut.riesenbeck at gmx.de
Thu Jun 2 19:37:50 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127717/
-----------------------------------------------------------
(Updated Juni 2, 2016, 7:37 nachm.)
Review request for KDE Edu.
Changes
-------
Corrected typo.
Repository: libkeduvocdocument
Description
-------
When a KEduVocDocument which was constructed by the default constructor
becomes destructed, the error message "QFile::remove: Empty or null
file name" is given on stderr.
Since the file name of the KAutoSaveFile was not set in the default
constructor, the KAutoSaveFile::remove() method in ~KEduVocDocument()
have given this error message. Removed this method call and the
following KAutoSaveFile::releaseLock(), because they are called in the
KAutoSaveFile destructor as well but with check for file name.
Added unit test emptydocumenttest to proof the bugfix.
Since I'm not a cmake expert, I hope the test was added in the right way. I would be thankful for improvements.
Diffs (updated)
-----
.gitignore PRE-CREATION
keduvocdocument/autotests/CMakeLists.txt 05580b6c5e8ad88fd15971cc6194aa4c22ffb558
keduvocdocument/autotests/emptydocumenttest.h PRE-CREATION
keduvocdocument/autotests/emptydocumenttest.cpp PRE-CREATION
keduvocdocument/keduvocdocument.cpp e8e48e90ef70477e18559936c3cb36fed492d543
Diff: https://git.reviewboard.kde.org/r/127717/diff/
Testing
-------
Unit test emptydocumenttest
Thanks,
Hartmut Riesenbeck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160602/b3214b50/attachment.html>
More information about the kde-edu
mailing list