Review Request 128078: Parley: Remember practice direction for each practice mode

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128078/#review96148
-----------------------------------------------------------



I like the new feature very much and I think the button is at the right position. However, I didn't understand the button text right away. Maybe "Remember Direction for each Mode separately" would be better? On the other hand, this would span two lines...

- Julian Helfferich


On June 1, 2016, 3:42 p.m., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128078/
> -----------------------------------------------------------
> 
> (Updated June 1, 2016, 3:42 p.m.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> New check box in StatistcsMainWindow is added. If check box is
> switched on the practice direction for the current practice mode is
> saved and will be restored when this practice mode is selected again.
> 
> This is a feature I personally missed. May it is usefull for the public.
> 
> But I am not shure if the location for the check box, which is switching 
> the feature on and off, is well choosen here in the main window (see 
> screenshot). Or if it's better placed in the practice configure dialog.
> 
> While working on this feature a smal bug was found in configuration 
> file saving. File was only saved when document was modified on 
> closing the application. Fixed it.
> 
> 
> Diffs
> -----
> 
>   src/parleydocument.cpp 2f5d3b32ba4462d6b9c917b109e0787cede59513 
>   src/parleymainwindow.cpp 9fd1b92e88ed2614f4f71579ed0f2a31fca027c3 
>   src/settings/parley.kcfg 7eac0d27a6d2f5dcb94d1ed5802b7c05b0ce4eb4 
>   src/statistics/statisticsmainwindow.h f6c87231010f672c0e32aae34345785d16484d75 
>   src/statistics/statisticsmainwindow.cpp 64c7ad64057e74da5ca81b098c0e865610900bb5 
>   src/statistics/statisticsmainwindow.ui 190017cc3ca788248aa468cc90349dde873fa80d 
> 
> Diff: https://git.reviewboard.kde.org/r/128078/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> screenshot01
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/06/01/0d19592c-0402-4b94-90e9-c5aa52fe54b6__screenshot01.png
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160602/3cb4fb6c/attachment-0001.html>