Review Request 128536: [parley] Change version string to script generated KDE Applications Version

[Burkhard Lück]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128536/#review97878
-----------------------------------------------------------



Makes a lot of sense, because:
the output of "app --version" = x.y in konsole does not display the Application version the app is released with
and the About dialog as well reports only "x.y" without the Application version, useless for me as well

- Burkhard Lück


On Juli 27, 2016, 1:19 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128536/
> -----------------------------------------------------------
> 
> (Updated Juli 27, 2016, 1:19 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> Since I noticed that parleys version string didn't changed for quite a long time, I make the suggestion to set it to the KDE Applications version like in many other KDE applications.
> 
> For my implementation I used the method descrbied here:
> https://community.kde.org/Guidelines_and_HOWTOs/Application_Versioning
> 
> This has the advantage that the version string is automaticly set to the current KDE Applictions Version by script. Wich makes it much easier to associate bugs from the bug tracking system the the appropriate version.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt dbc7a3f72e02d77d9e76338fe829852760affce4 
>   config-parley.h.cmake fba6bdb49c652cd15282a9cbafdf044202f2976b 
>   src/main.cpp 4a48b3f91db56cc8734ddd158673b5bce823b563 
>   src/parleydocument.cpp 8c4baf56d47196b054f890555e053d419bdcafdd 
>   src/version.h 868f971b1593bce963fcaaac495987006285cab1 
> 
> Diff: https://git.reviewboard.kde.org/r/128536/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160727/89c42af9/attachment.html>