Review Request 127157: Prevent array access with negativ index

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127157/#review92865
-----------------------------------------------------------


Ship it!




Ship It!

- Andreas Cord-Landwehr


On Feb. 23, 2016, 9:14 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127157/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 9:14 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> To adjust the practice date of expired entries
> in EntryFilter::expireEntries() the expire item
> time was read from the Prefs object. When grade
> of the expired item was 1, the argument of
> Prefs::expireItem() became -1. This resulted in
> an access of an C array with negativ index in
> Prefs::expireItem(). For grade 2 the prefs value
> was not defined in the config file - zero was
> returned by default. For this two cases the
> practice date was set to current time as a
> defined state.
> 
> 
> Diffs
> -----
> 
>   src/collection/entryfilter.cpp 5264226 
> 
> Diff: https://git.reviewboard.kde.org/r/127157/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160228/e2a80125/attachment.html>