Review Request 127155: Fix Bug 350887: Practise conjugations doesn't work

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127155/#review92864
-----------------------------------------------------------



Looks good to me, only spotted a minor issue.


src/collection/entryfilter.cpp (lines 57 - 58)
<https://git.reviewboard.kde.org/r/127155/#comment63334>

    please initialize them by the initializer list (this prevents that the default constructer is called unnecessarily)


- Andreas Cord-Landwehr


On Feb. 23, 2016, 10:30 vorm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127155/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 10:30 vorm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Bugs: 350887
>     http://bugs.kde.org/show_bug.cgi?id=350887
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> To make practice conjugations work two bugs had to be fixed:
> 
> The first bug was caused by uninitialized member variable m_toTranslation
> in EntryFilter constructor. This caused that DocumentSettings could
> not be loaded and EntryFilter::m_tenses was empty (later in 
> EntryFilter::cleanupInvalid method). Changed constructor to init 
> m_toTranslation from Prefs::learningLanguage() and m_fromTranslation 
> from Prefs::knownLanguage(). The second was not necessary to load the
> document settings, but was inserted for the sake of order.
> 
> The member m_tenses is used in EntryFilter::cleanupInvalid method to
> remove entries which don't have any of the tenses which are configured
> for practice. Now that document settings was not loaded propperly before,
> m_tenses is empty. Because m_tenses was empty, all entries were removed
> and the error dialog was shown.
> 
> After this was fixed, it came out that the conjugation prcatice widget
> didn't dispaly the verbs to_translation and from_translation. This was
> causd by an incomplete initialisation of TestEntry objects in
> EntryFilter::conjugationTestEntries method. This was fixed by init the
> To- and From-Language of each new test enty from m_toTranslation and
> m_fromTranslation of EntryFilter.
> 
> 
> Diffs
> -----
> 
>   src/collection/entryfilter.cpp 5264226 
> 
> Diff: https://git.reviewboard.kde.org/r/127155/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160228/a6df34b7/attachment.html>