Review Request 125303: [Cantor] Drop KGlobalSettings and implements a substitute to KGlobalSettings::kdisplayPaletteChanged

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125303/#review92414
-----------------------------------------------------------



I'm a bit late to this, but does this really work?

In KTextEditor, we install an event filter to the qApp, and check for the event type PaletteChange, and then update our caches.
Trying to use qApp::paletteChanged() does nothing when changing the KDE Color scheme...

Does this patch really work for Cantor???

- Dominik Haumann


On Sept. 18, 2015, 9:25 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125303/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 9:25 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal Humpula, and Jeremy Whiting.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Hi devs, I am finishing the drop of KDELibs4Support from Cantor. I am removing KGlobalSettings now, but I need to port kdisplayPaletteChanged signal. I wrote this patch based on this accepted review request [114619](https://git.reviewboard.kde.org/r/114619/) but I don't know if it is correct.
> 
> Well, just say me if it is ok for the moment. I don't know how to test specifically this feature.
> 
> 
> Diffs
> -----
> 
>   src/lib/defaulthighlighter.h e33256a 
>   src/lib/defaulthighlighter.cpp 45c7063 
> 
> Diff: https://git.reviewboard.kde.org/r/125303/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * Installation ok;
> * I used Cantor for some time, looks like ok.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160215/1d33a161/attachment.html>