Review Request 129612: [WIP] Showing custom context menu on multiple selection

Alexander Semke alexander.semke at web.de
Sun Dec 4 17:25:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129612/#review101271
-----------------------------------------------------------



In your new function ProjectExplorer::deleteSelected() loop over all selected model indices, determine the aspects via AbstractAspect* aspect = static_cast<AbstractAspect*>(index.internalPointer()) and call aspect->remove().

- Alexander Semke


On Dec. 4, 2016, 10:23 a.m., Garvit Khatri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129612/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 10:23 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Semke and Stefan Gerlach.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> This is still not complete, I wanted to ask how we can actually remove the aspects in function deleteSelected(). I know how I can remove them from m_treeview but that won't delete the aspect.
> 
> 
> Diffs
> -----
> 
>   src/commonfrontend/ProjectExplorer.h f94b918 
>   src/commonfrontend/ProjectExplorer.cpp 606a8cb 
> 
> Diff: https://git.reviewboard.kde.org/r/129612/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Garvit Khatri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20161204/95277a50/attachment.html>


More information about the kde-edu mailing list