Review Request 127558: Fix Coverty Scan ID 1342699 - Uninitialized pointer field

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127558/#review94542
-----------------------------------------------------------


Fix it, then Ship it!




Great! Found a last nit-pick. Please fix-it then push.


src/collection/entryfilterdialog.h (lines 18 - 19)
<https://git.reviewboard.kde.org/r/127558/#comment64291>

    minor nitpick: since Qt5 we do not use module includes anymore, just use:
    #include <QScopedPointer>
    #include <QDialog>


- Andreas Cord-Landwehr


On April 11, 2016, 7:42 nachm., Hartmut Riesenbeck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127558/
> -----------------------------------------------------------
> 
> (Updated April 11, 2016, 7:42 nachm.)
> 
> 
> Review request for KDE Edu.
> 
> 
> Repository: parley
> 
> 
> Description
> -------
> 
> One integer member m_numSets was initilized with 0 and two pointer
> members were removed by refactoring the EntryFilter class.
> 
> The code for a dialog window (where the two former pointers was used
> for) was moved into a new created class EntyFilterDialog. The dialog
> is now created as a stack object and will be removed properly when
> goes out of scope.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 43fa66085d1694049898a76433d94c66c4442239 
>   src/collection/collection.cpp 37b6b2e2cad56de9e6bdcead89f88063f8dde8d9 
>   src/collection/entryfilter.h ed49e6d642d4d12903d4ee0f384872c371d21e8d 
>   src/collection/entryfilter.cpp d332020da9cae17d221bd211950eb6349988a8e5 
>   src/collection/entryfilter.ui c5f3e4e2d3865dd2234474dd23328c25c5f3b029 
>   src/collection/entryfilterdialog.h PRE-CREATION 
>   src/collection/entryfilterdialog.cpp PRE-CREATION 
>   src/collection/entryfilterdialog.ui PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hartmut Riesenbeck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160411/1c1fc5e1/attachment.html>