Review Request 127596: Fixing error in request 127591 -porting KDialog

Stefan Gerlach stefan.gerlach at uni-konstanz.de
Thu Apr 7 08:36:08 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127596/#review94360
-----------------------------------------------------------


Ship it!




looks good for me.

- Stefan Gerlach


On April 7, 2016, 5:59 a.m., Anu Mittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127596/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 5:59 a.m.)
> 
> 
> Review request for KDE Edu and Alexander Semke.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Porting KDialog to QDialog.
> 
> 
> Diffs
> -----
> 
>   src/kdefrontend/datasources/FileInfoDialog.cpp 3ba90d1 
>   src/kdefrontend/datasources/ImportFileDialog.cpp e3783fe 
>   src/kdefrontend/spreadsheet/RandomValuesDialog.h fac308d 
>   src/kdefrontend/spreadsheet/RandomValuesDialog.cpp a1d5363 
>   src/kdefrontend/spreadsheet/SortDialog.cpp 2f7a0da 
> 
> Diff: https://git.reviewboard.kde.org/r/127596/diff/
> 
> 
> Testing
> -------
> 
> Successfully built.
> 
> 
> Thanks,
> 
> Anu Mittal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160407/746a0f1e/attachment.html>


More information about the kde-edu mailing list