Review Request 127591: Porting KDialog to QDialog
Garvit Khatri
garvitdelhi at gmail.com
Wed Apr 6 16:46:32 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127591/#review94337
-----------------------------------------------------------
src/kdefrontend/datasources/ImportFileDialog.cpp (line 50)
<https://git.reviewboard.kde.org/r/127591/#comment64151>
same here
src/kdefrontend/worksheet/ExportWorksheetDialog.cpp (line 38)
<https://git.reviewboard.kde.org/r/127591/#comment64150>
we don't need this as this is already imported in ExportWorksheetDialog.h
- Garvit Khatri
On April 6, 2016, 4:40 p.m., Anu Mittal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127591/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 4:40 p.m.)
>
>
> Review request for KDE Edu and Alexander Semke.
>
>
> Repository: labplot
>
>
> Description
> -------
>
> Removing obsolete functions and porting to Qt5 (KDialog to QDialog)
>
>
> Diffs
> -----
>
> src/kdefrontend/datasources/FileInfoDialog.h 111d1ba
> src/kdefrontend/datasources/FileInfoDialog.cpp 69246d3
> src/kdefrontend/datasources/ImportFileDialog.h 2d0f31c
> src/kdefrontend/datasources/ImportFileDialog.cpp 395906b
> src/kdefrontend/datasources/ImportFileWidget.cpp 29ada09
> src/kdefrontend/spreadsheet/RandomValuesDialog.h 3f0f1f6
> src/kdefrontend/spreadsheet/RandomValuesDialog.cpp 712ea60
> src/kdefrontend/spreadsheet/SortDialog.h 9b519d3
> src/kdefrontend/spreadsheet/SortDialog.cpp d97b2c2
> src/kdefrontend/worksheet/ExportWorksheetDialog.cpp e24b87b
>
> Diff: https://git.reviewboard.kde.org/r/127591/diff/
>
>
> Testing
> -------
>
> Successfully built.
>
>
> Thanks,
>
> Anu Mittal
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160406/5df4cd78/attachment.html>
More information about the kde-edu
mailing list