Review Request 127561: Prevent string cropping in bar widget and make practice button visible

[Dimitris Kardarakos]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127561/
-----------------------------------------------------------

(Updated April 3, 2016, 9:45 a.m.)


Review request for KDE Edu.


Changes
-------

Visual presentation of patch (with images)


Repository: parley


Description
-------

In dashboard page, a couple of issues have been identified in collection widget.
1. When the translation of string "%1 word due" is slightly longer than the English one or %1 is a large number, string is cropped.
2. Practice button does not seem clickable, using the default breeze theme and reference theme of parley. Even worse, when breeze dark is used, due to the forcibly white background of collection widget, practice button text is unreadable.
I have addressed these issues by:
- Changing bar widget size to 2-lines, increasing also slightly the width of the collection widget
- Wrapping the text of bar widget
- Restoring theme colors to practice button (background was set to white due to collection widget white background)


Diffs
-----

  src/dashboard/barwidget.cpp 61b6e43 
  src/dashboard/collectionwidget.cpp 7925871 

Diff: https://git.reviewboard.kde.org/r/127561/diff/


Testing
-------

Checked bar widget string presentation as well as practice button visibility using combinations of the following:

- Plasma Breeze (default) theme
- Plasma Breeze Dark theme
- Parley default theme
- Parley bees theme


File Attachments (updated)
----------------

Dashboard (before patch)
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/03/2c264833-6deb-41c0-bb8d-fff1fb242564__before.png
Dashboard (after patching)
  https://git.reviewboard.kde.org/media/uploaded/files/2016/04/03/c23368b9-482c-4d5d-8633-9c220428cbbc__after.png


Thanks,

Dimitris Kardarakos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160403/d061a5f5/attachment.html>