Review Request 127547: CMakeLists.txt find_package contains some unwanted includes under KF5 required components.

Anu Mittal anu22mittal at gmail.com
Fri Apr 1 17:19:58 UTC 2016



> On April 1, 2016, 3:53 p.m., Stefan Gerlach wrote:
> > Ship It!

Hey, I guess you have committed the change under your name instead of committing on my behalf.
I just got to know when I was about to commit it.


- Anu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127547/#review94191
-----------------------------------------------------------


On April 1, 2016, 3:26 p.m., Anu Mittal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127547/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 3:26 p.m.)
> 
> 
> Review request for KDE Edu and Alexander Semke.
> 
> 
> Repository: labplot
> 
> 
> Description
> -------
> 
> Removing unwanted KF5 required component.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 37352b9 
> 
> Diff: https://git.reviewboard.kde.org/r/127547/diff/
> 
> 
> Testing
> -------
> 
> Re-built after removing the components.
> Result : LabPlot successfully built
> 
> 
> Thanks,
> 
> Anu Mittal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20160401/a71c30d9/attachment.html>


More information about the kde-edu mailing list