Review Request 125406: Restore configure dialog, remove command line warnings

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125406/
-----------------------------------------------------------

(Updated Sept. 26, 2015, 11:37 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu and Andrius Štikonas.


Changes
-------

Submitted with commit 2626de747f683f707478baa3a85c274295bf5ddc by Luigi Toscano to branch Applications/15.08.


Bugs: 349984
    http://bugs.kde.org/show_bug.cgi?id=349984


Repository: kbruch


Description
-------

This review is for two small changes, partially related:

---
    Remove warning about setXMLFile
    
    ::createGUI complains that setXMLFile is called, and then createGUI or
    setupGUI. According the documentation, if createGUI is manually called,
    the "Create" flag should be removed from the setupGUI call.
---
    Restore slot definition
    
    Otherwise at least old type connection (like KStandardActions)
    do not work and a warning is printed.
    
    BUG: 349984
---


Diffs
-----

  src/FractionRingWidget.h 3be8857 
  src/FractionRingWidget.cpp 69a3d6e 
  src/MainQtWidget.h 7852733 

Diff: https://git.reviewboard.kde.org/r/125406/diff/


Testing
-------

Less messages on the command line; configure dialog can be accessed.


Thanks,

Luigi Toscano

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150926/82cff921/attachment.html>