Review Request 125406: Restore configure dialog, remove command line warnings
Luigi Toscano
luigi.toscano at tiscali.it
Sat Sep 26 13:27:40 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125406/
-----------------------------------------------------------
Review request for KDE Edu and Andrius Štikonas.
Bugs: 349984
http://bugs.kde.org/show_bug.cgi?id=349984
Repository: kbruch
Description
-------
This review is for two small changes, partially related:
---
Remove warning about setXMLFile
::createGUI complains that setXMLFile is called, and then createGUI or
setupGUI. According the documentation, if createGUI is manually called,
the "Create" flag should be removed from the setupGUI call.
---
Restore slot definition
Otherwise at least old type connection (like KStandardActions)
do not work and a warning is printed.
BUG: 349984
---
Diffs
-----
src/FractionRingWidget.h 3be8857
src/FractionRingWidget.cpp 69a3d6e
src/MainQtWidget.h 7852733
Diff: https://git.reviewboard.kde.org/r/125406/diff/
Testing
-------
Less messages on the command line; configure dialog can be accessed.
Thanks,
Luigi Toscano
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150926/45743f9a/attachment.html>
More information about the kde-edu
mailing list