Review Request 125303: [Cantor] Drop KGlobalSettings and implements a substitute to KGlobalSettings::kdisplayPaletteChanged

Filipe Saraiva filipe at kde.org
Fri Sep 18 21:25:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125303/
-----------------------------------------------------------

(Updated Sept. 18, 2015, 9:25 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal Humpula, and Jeremy Whiting.


Changes
-------

Submitted with commit b0ba31c71348d4924d9db561d1d54751a9d52b37 by Filipe Saraiva to branch master.


Repository: cantor


Description
-------

Hi devs, I am finishing the drop of KDELibs4Support from Cantor. I am removing KGlobalSettings now, but I need to port kdisplayPaletteChanged signal. I wrote this patch based on this accepted review request [114619](https://git.reviewboard.kde.org/r/114619/) but I don't know if it is correct.

Well, just say me if it is ok for the moment. I don't know how to test specifically this feature.


Diffs
-----

  src/lib/defaulthighlighter.h e33256a 
  src/lib/defaulthighlighter.cpp 45c7063 

Diff: https://git.reviewboard.kde.org/r/125303/diff/


Testing
-------

* Build ok;
* Installation ok;
* I used Cantor for some time, looks like ok.


Thanks,

Filipe Saraiva

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150918/e3377e7f/attachment-0001.html>


More information about the kde-edu mailing list