Review Request 125303: [Cantor] Drop KGlobalSettings and implements a substitute to KGlobalSettings::kdisplayPaletteChanged

[Jeremy Whiting]

> On Sept. 18, 2015, 2:08 p.m., Jeremy Whiting wrote:
> > This looks good, but couldn't you simply connect the slot to the QApplication paletteChanged signal instead of adding an event filter? http://doc.qt.io/qt-5/qguiapplication.html#paletteChanged
> 
> Filipe Saraiva wrote:
>     Thanks Jeremy. The idea is interesting but I don't know if I can to get the QApplication reference because this code is in cantorlibs. I am trying to follow your tip.

Filipe, you should be able to access it by #include <QApplication> and use qApp to get the application pointer.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125303/#review85639
-----------------------------------------------------------


On Sept. 18, 2015, 2:21 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125303/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 2:21 p.m.)
> 
> 
> Review request for KDE Edu, Aleix Pol Gonzalez, Alexander Rieder, Michal Humpula, and Jeremy Whiting.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Hi devs, I am finishing the drop of KDELibs4Support from Cantor. I am removing KGlobalSettings now, but I need to port kdisplayPaletteChanged signal. I wrote this patch based on this accepted review request [114619](https://git.reviewboard.kde.org/r/114619/) but I don't know if it is correct.
> 
> Well, just say me if it is ok for the moment. I don't know how to test specifically this feature.
> 
> 
> Diffs
> -----
> 
>   src/lib/defaulthighlighter.h e33256a 
>   src/lib/defaulthighlighter.cpp 45c7063 
>   src/worksheettextitem.cpp 9fba297 
> 
> Diff: https://git.reviewboard.kde.org/r/125303/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * Installation ok;
> * I used Cantor for some time, looks like ok.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150918/9f5310e0/attachment-0001.html>