Review Request 125203: KF5 port

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125203/#review85278
-----------------------------------------------------------


Mostly good, but the changes in src/detailinfodlg.cpp are wrong. You need to port away from KLocale to QLocale, not add new uses of KLocale.

- Jeremy Whiting


On Sept. 12, 2015, 2:17 p.m., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125203/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 2:17 p.m.)
> 
> 
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Port of KGlobal::locale()
> 
> 
> Diffs
> -----
> 
>   plasmoid/applet/nuclearPlasmoid/nuclearCalculator.cpp dfcbc6d 
>   plasmoid/applet/psePlasmoid/Molmasscalculator.cpp ccf7d27 
>   plasmoid/engine/kalzium_engine.cpp da44c17 
>   src/detailinfodlg.cpp d8a3968 
>   src/kalzium.cpp fec6aa7 
>   src/tools/moleculeview.cpp a586b6d 
> 
> Diff: https://git.reviewboard.kde.org/r/125203/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150912/632f7b2a/attachment.html>