Review Request 125188: KF5 port

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125188/#review85245
-----------------------------------------------------------


Besides the small issues, please remove all double empty lines and also all empty lines between the include headers.


src/main.cpp (line 149)
<https://git.reviewboard.kde.org/r/125188/#comment58926>

    this is a memleak, please create object on the stack instead on the heap



src/main.cpp (line 180)
<https://git.reviewboard.kde.org/r/125188/#comment58925>

    remove line


- Andreas Cord-Landwehr


On Sept. 12, 2015, 9:54 vorm., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125188/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2015, 9:54 vorm.)
> 
> 
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Port K4AboutData -> KAboutData  and  KCmdLineArgs -> QCommandLineParser
> 
> 
> Diffs
> -----
> 
>   compoundviewer/kalziumglpart.cpp 825077d 
>   src/main.cpp 48d40ca 
> 
> Diff: https://git.reviewboard.kde.org/r/125188/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150912/30566aea/attachment.html>