Review Request 125173: Port KStandardDirs -> QStandardPaths

[Andreas Cord-Landwehr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125173/#review85215
-----------------------------------------------------------


In general looks fine, only some newly introduced coding style errors left.


plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp (line 114)
<https://git.reviewboard.kde.org/r/125173/#comment58904>

    coding style: space before operator =



src/calculator/calculator.cpp (line 25)
<https://git.reviewboard.kde.org/r/125173/#comment58920>

    remove this line



src/detailedQmlView.cpp (line 26)
<https://git.reviewboard.kde.org/r/125173/#comment58905>

    coding style, as above



src/detailedgraphicaloverview.cpp (line 92)
<https://git.reviewboard.kde.org/r/125173/#comment58906>

    coding style, as above



src/detailinfodlg.cpp (line 62)
<https://git.reviewboard.kde.org/r/125173/#comment58908>

    coding style, as above



src/detailinfodlg.cpp (line 64)
<https://git.reviewboard.kde.org/r/125173/#comment58907>

    coding style, as above



src/kalzium.cpp (line 345)
<https://git.reviewboard.kde.org/r/125173/#comment58909>

    coding style, as above



src/kalzium.cpp (line 589)
<https://git.reviewboard.kde.org/r/125173/#comment58910>

    coding style, as above



src/kalziumdataobject.cpp (line 201)
<https://git.reviewboard.kde.org/r/125173/#comment58911>

    coding style, as above



src/kalziumschemetype.cpp (line 461)
<https://git.reviewboard.kde.org/r/125173/#comment58912>

    coding style, as above



src/kalziumschemetype.cpp (line 511)
<https://git.reviewboard.kde.org/r/125173/#comment58913>

    coding style, as above



src/kalziumschemetype.cpp (line 557)
<https://git.reviewboard.kde.org/r/125173/#comment58914>

    coding style, as above



src/kalziumschemetype.cpp (line 614)
<https://git.reviewboard.kde.org/r/125173/#comment58915>

    coding style, as above



src/molcalcwidget.cpp (line 39)
<https://git.reviewboard.kde.org/r/125173/#comment58916>

    remove this line



src/tablesdialog.cpp (line 19)
<https://git.reviewboard.kde.org/r/125173/#comment58917>

    remove this line



src/tools/moleculeview.cpp (line 28)
<https://git.reviewboard.kde.org/r/125173/#comment58919>

    remove this line



src/tools/moleculeview.cpp (line 178)
<https://git.reviewboard.kde.org/r/125173/#comment58918>

    coding style, see above


- Andreas Cord-Landwehr


On Sept. 11, 2015, 7:09 nachm., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125173/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 7:09 nachm.)
> 
> 
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Port away from KStandardDirs to QStandardPaths
> 
> 
> Diffs
> -----
> 
>   libscience/moleculeparser.cpp 35321cc 
>   plasmoid/applet/nuclearPlasmoid/kalziumdataobject.cpp 27c1c61 
>   plasmoid/engine/kalzium_engine.cpp ea24caa 
>   src/calculator/calculator.cpp d343a07 
>   src/detailedQmlView.cpp 50321f5 
>   src/detailedgraphicaloverview.cpp cd792ac 
>   src/detailinfodlg.cpp ad55f38 
>   src/kalzium.cpp fc8ff50 
>   src/kalziumdataobject.cpp e123415 
>   src/kalziumschemetype.cpp d35a97c 
>   src/molcalcwidget.cpp af7c589 
>   src/tablesdialog.cpp 58518b5 
>   src/tools/moleculeview.cpp c70fb1e 
> 
> Diff: https://git.reviewboard.kde.org/r/125173/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150911/f397934e/attachment-0001.html>