Review Request 125166: filter bug fixed

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125166/#review85183
-----------------------------------------------------------



src/editor.cpp (line 165)
<https://git.reviewboard.kde.org/r/125166/#comment58894>

    This is the wrong fix. the %1 and %2 no longer correspond to any .arg, so should be removed. You also removed the i18n() calls which mark strings to be translated. The right fix would be:
    
    QString("%1 (*.turtle);;%2 (*)").arg(i18n("Turtle code files")).arg(i18n("All files"))



src/editor.cpp (line 177)
<https://git.reviewboard.kde.org/r/125166/#comment58895>

    This whitespace change is wrong and has nothing to do with the other changes.



src/editor.cpp (line 267)
<https://git.reviewboard.kde.org/r/125166/#comment58896>

    This is wrong and should be the same as the previous, the translatable strings need to be wrapped in i18n() calls and the file format names don't.



src/mainwindow.cpp (line 1055)
<https://git.reviewboard.kde.org/r/125166/#comment58897>

    Same as above, don't remove i18n calls. Maybe read the QString .arg() documentation to see how it works.


- Jeremy Whiting


On Sept. 11, 2015, 7:29 a.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125166/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 7:29 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: kturtle
> 
> 
> Description
> -------
> 
> filter bug fixed
> 
> 
> Diffs
> -----
> 
>   src/editor.cpp 99a56eb 
>   src/mainwindow.cpp 80eca29 
> 
> Diff: https://git.reviewboard.kde.org/r/125166/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150911/12a96f66/attachment.html>