Review Request 125157: Port KTabWidget -> QTabWidget

Andreas Cord-Landwehr cordlandwehr at kde.org
Fri Sep 11 10:39:42 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125157/#review85168
-----------------------------------------------------------


only two minor cleanups left, else looks fine


src/kalzium.h (line 26)
<https://git.reviewboard.kde.org/r/125157/#comment58889>

    not needed, please remove



src/kalzium.cpp (line 70)
<https://git.reviewboard.kde.org/r/125157/#comment58888>

    if it is not used, please remove


- Andreas Cord-Landwehr


On Sept. 11, 2015, 10:23 vorm., Rahul Chowdhury wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125157/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2015, 10:23 vorm.)
> 
> 
> Review request for KDE Edu, Andreas Cord-Landwehr and Jeremy Whiting.
> 
> 
> Repository: kalzium
> 
> 
> Description
> -------
> 
> Port away from KTabWidget to QTabWidget
> 
> 
> Diffs
> -----
> 
>   src/calculator/titrationCalculator.ui df0569f 
>   src/kalzium.h 86e4a6d 
>   src/kalzium.cpp 50beac1 
>   src/settings_colors.ui 63f96a8 
>   src/tools/moleculeviewerwidget.ui 2cb2c7c 
> 
> Diff: https://git.reviewboard.kde.org/r/125157/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahul Chowdhury
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150911/9d7121bc/attachment.html>


More information about the kde-edu mailing list