Review Request 125141: porting away from kdelibs44support

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125141/#review85126
-----------------------------------------------------------


Looks good except for these two items. Please fix them first then it's good to push.


src/main.cpp (line 55)
<https://git.reviewboard.kde.org/r/125141/#comment58862>

    Please use the same indentation as the rest of the existing code.



src/main.cpp (line 73)
<https://git.reviewboard.kde.org/r/125141/#comment58861>

    As the porting script says, move this after all the addOption calls.


L

- Jeremy Whiting


On Sept. 10, 2015, 10:06 a.m., Sayan Biswas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125141/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 10:06 a.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: kturtle
> 
> 
> Description
> -------
> 
> porting of kcmdlineargs, kapplication and kaboutdata
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 7c57955 
> 
> Diff: https://git.reviewboard.kde.org/r/125141/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sayan Biswas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150910/7f85a0b7/attachment.html>