Review Request 124851: Adjust location for kvtml files

Jeremy Whiting jpwhiting at kde.org
Tue Sep 1 01:44:15 UTC 2015



> On Aug. 26, 2015, 8:25 p.m., Jeremy Whiting wrote:
> > For backwards compatibility, let's keep apps/kvtml for the time being. We can look at using just kvtml later on if there's a strong reason for doing so. I just pushed a fix to kanagram's knsrc file so knewstuff files will go to the right place (pushed to Applications/15.04, Applications/15.08 and master branches).

Heiko, If what's in master works for you now, please close/discard this review and the other one. If not tell me what's not working and let's work on a solution that will fix it.

thanks,
Jeremy


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124851/#review84437
-----------------------------------------------------------


On Aug. 20, 2015, 2:50 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124851/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 2:50 p.m.)
> 
> 
> Review request for KDE Edu and Jeremy Whiting.
> 
> 
> Repository: libkeduvocdocument
> 
> 
> Description
> -------
> 
> QStandardPaths::GenericDataLocation returns "~/.local/share" as a
> writable path, which is not only a path which should be the default for
> $XDG_DATA_HOME [1] but is also the directory, where knewstuff puts
> downloaded files.
> 
> Without this patch previously downloaded vocabularies which ended up
> in ~/.local/share/kvtml weren't found in kanagram, because it only
> searched in ~/.local/share/apps/kvtml.
> 
> [1] http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
> 
> 
> Diffs
> -----
> 
>   keduvocdocument/sharedkvtmlfiles.cpp f153385b5d28eb807deaf7be6eed12e892056f75 
> 
> Diff: https://git.reviewboard.kde.org/r/124851/diff/
> 
> 
> Testing
> -------
> 
> Vocabularies downloaded via knewstuff now show up in kanagram.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150901/e02838c9/attachment.html>


More information about the kde-edu mailing list