Review Request 125981: Search box resetting after 50 lookups

Dametrious Peyton dametriouspeyton at countermail.com
Fri Nov 6 23:28:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125981/
-----------------------------------------------------------

Review request for KDE Edu.


Repository: kiten


Description
-------

After reaching the maximum history count (about 50 by default), the combo box would remove the searched item and replace it with the last entry in the history. The fix is to add the last searched item to the history, set the item in the combo box, and reset the history to sync.
    
    reset() is required according to the KDE API Doc. http://api.kde.org/frameworks-api/frameworks5-apidocs/kcompletion/html/classKHistoryComboBox.html#af6ef37548be290c810e1603350393780


Diffs
-----

  app/searchstringinput.cpp ac0130b 

Diff: https://git.reviewboard.kde.org/r/125981/diff/


Testing
-------

Did functional testing with the search box


Thanks,

Dametrious Peyton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20151106/3e44a8c4/attachment.html>


More information about the kde-edu mailing list