Review Request 123885: Port from KTemporaryFile to QTemporaryFile

[Filipe Saraiva]

> On Maio 24, 2015, 2:43 p.m., Aleix Pol Gonzalez wrote:
> > src/lib/latexrenderer.cpp, line 175
> > <https://git.reviewboard.kde.org/r/123885/diff/1/?file=370562#file370562line175>
> >
> >     This dir is not being used anymore, is it?
> 
> Filipe Saraiva wrote:
>     It is used in line 203:
>     
>     >202. KProcess *p=new KProcess( this );
>     >203. p->setWorkingDirectory(dir);
>     
>     Of course it is possible to do some code refactoring here.
> 
> Aleix Pol Gonzalez wrote:
>     Then you probably want to use dir instead of QDir::tempPath(), no?

Yes, sure!
Thanks for the tip.


- Filipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123885/#review80771
-----------------------------------------------------------


On Maio 24, 2015, 4:12 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123885/
> -----------------------------------------------------------
> 
> (Updated Maio 24, 2015, 4:12 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KTemporaryFile is deprecated for KF5. The library was ported to QTemporaryFile.
> 
> 
> Diffs
> -----
> 
>   src/backends/maxima/maximaexpression.h 910582b 
>   src/backends/maxima/maximaexpression.cpp 8c73564 
>   src/backends/qalculate/qalculateexpression.h e97a814 
>   src/backends/qalculate/qalculateexpression.cpp 00eacb1 
>   src/lib/latexrenderer.cpp 348e9bc 
>   src/scripteditorwidget.h 527d02e 
>   src/scripteditorwidget.cpp 1208c68 
> 
> Diff: https://git.reviewboard.kde.org/r/123885/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * Plot generated by Maxima and added in worksheet ok;
> * Plot generated by Qalculate and added in worksheet ok;
> * LaTeX entries ok;
> * Script processing ok.
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150524/443e9976/attachment.html>