Review Request 123840: Port KDoubleNumInput to QDoubleSpinBox

Aleix Pol Gonzalez aleixpol at kde.org
Mon May 18 22:32:47 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123840/#review80610
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 18, 2015, 8:10 p.m., Filipe Saraiva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123840/
> -----------------------------------------------------------
> 
> (Updated May 18, 2015, 8:10 p.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> KDoubleNumInput is deprecated for KF5. The [documentation](http://api.kde.org/frameworks-api/frameworks5-apidocs/kdelibs4support/html/classKDoubleNumInput.html) recommends to change for QSpinBox, but there is a [QDoubleSpinBox](http://doc.qt.io/qt-5/qdoublespinbox.html) class more close to KDoubleNumInput. Maybe is it an error on KDELibs4Support documentation?
> 
> 
> Diffs
> -----
> 
>   src/imagesettings.ui 13b7f97 
> 
> Diff: https://git.reviewboard.kde.org/r/123840/diff/
> 
> 
> Testing
> -------
> 
> * Build ok;
> * I can to load an image on worksheet correctly (Mouse button 2 on worksheet > Insert > Image; button 2 to load image > select some image > change the values presented > Ok).
> 
> 
> Thanks,
> 
> Filipe Saraiva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150518/6876caa1/attachment-0001.html>


More information about the kde-edu mailing list