Review Request 123825: [Cantor] KStandardDirs ported to QSrandardPaths
Filipe Saraiva
filipe at kde.org
Mon May 18 00:32:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123825/
-----------------------------------------------------------
(Updated May 18, 2015, 12:32 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Edu, Alexander Rieder, Lucas Hermann Negri, and Minh Ngo.
Changes
-------
Submitted with commit 2af4705c3391345444c95a6e63a84355fa6d66ac by Filipe Saraiva to branch master.
Repository: cantor
Description
-------
KStandardDirs is deprecated for KF5. The library was ported to QStandardPaths. I used [porting notes page](https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs) about KStandardDirs to do it.
Diffs
-----
src/backends/R/rbackend.cpp e128520
src/backends/R/rsession.cpp 1d1aeac
src/backends/maxima/maximakeywords.cpp 1ea1a5c
src/backends/maxima/maximasession.cpp a150194
src/backends/maxima/testmaxima.cpp 65111aa
src/backends/python/pythonextensions.cpp 665a628
src/backends/python/pythonkeywords.cpp e3e425c
src/backends/python3/python3session.cpp 5846ba1
src/backends/sage/sagekeywords.cpp 2b6f763
src/backends/scilab/scilabkeywords.cpp 0ac8003
src/cantor.cpp 25d15b6
src/latexentry.cpp 0b8321d
src/lib/expression.cpp 2fb9286
src/lib/latexrenderer.cpp 75f7cda
src/loadedexpression.cpp 02c8790
src/worksheet.cpp 9ff8cf1
Diff: https://git.reviewboard.kde.org/r/123825/diff/
Testing
-------
Tests performed:
* Maxima keywords loaded;
* Can find Python 3 executable and can run it;
* Sage keywords loaded;
* Open examples;
* Process latex entries correctly;
* Export to latex format working correctly.
Missing tests:
* Run and find R executable (I do not have R in my machine).
Thanks,
Filipe Saraiva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150518/ccf4f975/attachment-0001.html>
More information about the kde-edu
mailing list