Review Request 123312: I have added KMessageBox::warningYesNoCancel if someone has unsaved changes left when closing the application.

[Garvit Khatri]

> On May 9, 2015, 4:59 p.m., Filipe Saraiva wrote:
> > Thanks Garvit, your contribution is an improvement for Cantor.
> > 
> > But this feature needs to aim more 2 specific cases:
> > 
> > * If I press "Save" in the dialog and after I press "Cancel", Cantor must not be closed. You can verify the correct behaviour in others software, like kate or kile.
> > * If I am working in more than one worksheet in the same time, the warning dialog is presented only for one worksheet. The feature needs to verify if there are more worksheets to be saved.
> > 
> > Try to provide those improvements and your contribution will be accepeted in code base. =)

I have added both the things though i haven't added the dialog for multiple open worksheets like Kate. If that is required do inform me.


- Garvit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123312/#review80127
-----------------------------------------------------------


On May 16, 2015, 11:58 a.m., Garvit Khatri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123312/
> -----------------------------------------------------------
> 
> (Updated May 16, 2015, 11:58 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=324581
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=324581
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Warning about unsaved data in cantor
> 
> 
> Diffs
> -----
> 
>   src/cantor.h b675e35 
>   src/cantor.cpp 482c3f8 
> 
> Diff: https://git.reviewboard.kde.org/r/123312/diff/
> 
> 
> Testing
> -------
> 
> I have tested it on KF5.
> 
> 
> Thanks,
> 
> Garvit Khatri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150516/a41ae8fe/attachment.html>