Review Request 123394: FindLibSpectre: Use FindPkgConfig instead of UsePkgConfig

Filipe Saraiva filipe at kde.org
Sat May 9 17:13:37 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123394/#review80130
-----------------------------------------------------------

Ship it!


Thanks!
Please, send it directly for master branch and remember to use the [Review magic word](https://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages) in commit message.

- Filipe Saraiva


On Abril 19, 2015, 1:15 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123394/
> -----------------------------------------------------------
> 
> (Updated Abril 19, 2015, 1:15 p.m.)
> 
> 
> Review request for KDE Edu and Filipe Saraiva.
> 
> 
> Bugs: 346283
>     http://bugs.kde.org/show_bug.cgi?id=346283
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
> 
> 
> Diffs
> -----
> 
>   cmake/FindLibSpectre.cmake 8d5dc76 
> 
> Diff: https://git.reviewboard.kde.org/r/123394/diff/
> 
> 
> Testing
> -------
> 
> Configured and built cantor successfully and checked that it links to libspectre.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150509/8275a01c/attachment-0001.html>


More information about the kde-edu mailing list