Review Request 123398: FindQalculate: Use FindPkgConfig instead of UsePkgConfig

Filipe Saraiva filipe at kde.org
Sat May 9 17:09:36 UTC 2015



> On Maio 9, 2015, 5:08 p.m., Filipe Saraiva wrote:
> > Thanks!
> > Please, send it directly for master branch and remember to use the [https://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages](REVIEW magic word) in commit message.

Thanks!
Please, send it directly for master branch and remember to use the [Review magic word](https://techbase.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages) in commit message.


- Filipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123398/#review80128
-----------------------------------------------------------


On Abril 17, 2015, 1:28 p.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123398/
> -----------------------------------------------------------
> 
> (Updated Abril 17, 2015, 1:28 p.m.)
> 
> 
> Review request for KDE Edu and Filipe Saraiva.
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> The latter is deprecated and doesn't respect the PKG_CONFIG
> environment variable which makes it easy to deal with differently
> named pkg-config executables, e.g. arch-prefixed ones.
> 
> 
> Diffs
> -----
> 
>   cmake/FindQalculate.cmake 707a9f7 
> 
> Diff: https://git.reviewboard.kde.org/r/123398/diff/
> 
> 
> Testing
> -------
> 
> Configured, built and checked that cantor links to qualculate and cln.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150509/46c4ea03/attachment.html>


More information about the kde-edu mailing list