Review Request 123312: I have added KMessageBox::warningYesNoCancel if someone has unsaved changes left when closing the application.

[Filipe Saraiva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123312/#review80127
-----------------------------------------------------------


Thanks Garvit, your contribution is an improvement for Cantor.

But this feature needs to aim more 2 specific cases:

* If I press "Save" in the dialog and after I press "Cancel", Cantor must not be closed. You can verify the correct behaviour in others software, like kate or kile.
* If I am working in more than one worksheet in the same time, the warning dialog is presented only for one worksheet. The feature needs to verify if there are more worksheets to be saved.

Try to provide those improvements and your contribution will be accepeted in code base. =)

- Filipe Saraiva


On Abril 17, 2015, 10:45 a.m., Garvit Khatri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123312/
> -----------------------------------------------------------
> 
> (Updated Abril 17, 2015, 10:45 a.m.)
> 
> 
> Review request for KDE Edu, Alexander Rieder and Filipe Saraiva.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=324581
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=324581
> 
> 
> Repository: cantor
> 
> 
> Description
> -------
> 
> Warning about unsaved data in cantor
> 
> 
> Diffs
> -----
> 
>   src/cantor.h c703f5d 
>   src/cantor.cpp 16eb7d9 
> 
> Diff: https://git.reviewboard.kde.org/r/123312/diff/
> 
> 
> Testing
> -------
> 
> I have tested it on KF5.
> 
> 
> Thanks,
> 
> Garvit Khatri
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20150509/a99cd1d0/attachment.html>